From 5c4f5698570cd817ebb62c573b6982627ff5e765 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 15 Nov 2018 16:47:44 -0800 Subject: [PATCH] doc: simplify first-time contributors section of Collaborator Guide PR-URL: https://github.com/nodejs/node/pull/24387 Reviewed-By: Ouyang Yadong Reviewed-By: Weijia Wang Reviewed-By: Refael Ackermann Reviewed-By: Franziska Hinkelmann Reviewed-By: Trivikram Kamat Reviewed-By: Vse Mozhet Byt --- COLLABORATOR_GUIDE.md | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index deadf87ed15092..1eb75fc1f8d703 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -50,16 +50,14 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). ### Welcoming First-Time Contributors -Courtesy should always be shown to individuals submitting issues and pull -requests to the Node.js project. Be welcoming to first-time contributors, -identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png) -badge. +Always show courtesy to individuals submitting issues and pull requests. Be +welcoming to first-time contributors, identified by the GitHub +![First-time contributor](./doc/first_timer_badge.png) badge. -For first-time contributors, check if the commit author is the same as the -pull request author, and ask if they have configured their git +For first-time contributors, check if the commit author is the same as the pull +request author. This way, once their pull request lands, GitHub will show them +as a _Contributor_. Ask if they have configured their git [username][git-username] and [email][git-email] to their liking. -This is to make sure they would be promoted to "contributor" once their -pull request lands. ### Closing Issues and Pull Requests