From 5e268b8dbead4d71394353a2154ff5798880e1db Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sat, 14 Dec 2019 21:05:27 -0500 Subject: [PATCH] test: simplify test-wasi-start-validation.js This commit removes an extra block scope, and avoid reading the simple.wasm file for every test case. PR-URL: https://github.com/nodejs/node/pull/30972 Reviewed-By: Jiawen Geng Reviewed-By: Rich Trott Reviewed-By: James M Snell --- test/wasi/test-wasi-start-validation.js | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/test/wasi/test-wasi-start-validation.js b/test/wasi/test-wasi-start-validation.js index 3f530a42f791f8..8c8c6f7e44acc6 100644 --- a/test/wasi/test-wasi-start-validation.js +++ b/test/wasi/test-wasi-start-validation.js @@ -6,6 +6,7 @@ const assert = require('assert'); const { WASI } = require('wasi'); const fixtures = require('../common/fixtures'); +const bufferSource = fixtures.readSync('simple.wasm'); { const wasi = new WASI(); @@ -17,23 +18,19 @@ const fixtures = require('../common/fixtures'); ); } -{ +(async () => { const wasi = new WASI({}); - (async () => { - const bufferSource = fixtures.readSync('simple.wasm'); - const wasm = await WebAssembly.compile(bufferSource); - const instance = await WebAssembly.instantiate(wasm); + const wasm = await WebAssembly.compile(bufferSource); + const instance = await WebAssembly.instantiate(wasm); - assert.throws( - () => { wasi.start(instance); }, - { code: 'ERR_INVALID_ARG_TYPE', message: /\bWebAssembly\.Memory\b/ } - ); - })(); -} + assert.throws( + () => { wasi.start(instance); }, + { code: 'ERR_INVALID_ARG_TYPE', message: /\bWebAssembly\.Memory\b/ } + ); +})(); (async () => { const wasi = new WASI(); - const bufferSource = fixtures.readSync('simple.wasm'); const wasm = await WebAssembly.compile(bufferSource); const instance = await WebAssembly.instantiate(wasm); const values = [undefined, null, 'foo', 42, true, false, () => {}]; @@ -54,7 +51,6 @@ const fixtures = require('../common/fixtures'); (async () => { const wasi = new WASI(); - const bufferSource = fixtures.readSync('simple.wasm'); const wasm = await WebAssembly.compile(bufferSource); const instance = await WebAssembly.instantiate(wasm); @@ -79,7 +75,6 @@ const fixtures = require('../common/fixtures'); (async () => { const wasi = new WASI(); - const bufferSource = fixtures.readSync('simple.wasm'); const wasm = await WebAssembly.compile(bufferSource); const instance = await WebAssembly.instantiate(wasm);