From 5fdfcc069f2464498bcbf13305fee56414ad2340 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 16 Jul 2021 07:12:36 -0700 Subject: [PATCH] doc: remove outdated step in onboarding exercise The GitHub bot will leave a comment asking people to thumbs-up a fast track request so there is no need to manually leave such a comment. PR-URL: https://github.com/nodejs/node/pull/39410 Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell --- onboarding.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/onboarding.md b/onboarding.md index adcf23f41abad4..ae65f07f37b621 100644 --- a/onboarding.md +++ b/onboarding.md @@ -204,12 +204,12 @@ needs to be pointed out separately during the onboarding. so that when the commit lands, the nomination issue url will be automatically closed. * Label your pull request with the `doc`, `notable-change`, and `fast-track` - labels. + labels. The `fast-track` label should cause the Node.js GitHub bot to post a + comment in the pull request asking collaborators to approve the pull request + by leaving a 👍 reaction on the comment. * Run CI on the pull request. Use the `node-test-pull-request` CI task. * After two Collaborator approvals for the change and two Collaborator approvals - for fast-tracking, land the pull request. -* Leave a comment in the pull request: - `Please 👍 this comment to approve fast-tracking`. + for fast-tracking, land the PR. * If there are not enough approvals within a reasonable time, consider the single approval of the onboarding TSC member sufficient, and land the pull request.