From 6fe278d1cbdd9c38ef75bc252fb0f8d88afd93fd Mon Sep 17 00:00:00 2001 From: Bartosz Sosnowski Date: Wed, 21 Nov 2018 14:28:24 +0100 Subject: [PATCH] build, tools, win: add .S files support to GYP Makes GYP properly handle .S files. Fixes: https://github.com/nodejs/node-v8/issues/89 PR-URL: https://github.com/nodejs/node/pull/24553 Reviewed-By: Refael Ackermann Reviewed-By: Richard Lau Reviewed-By: Anna Henningsen --- tools/gyp/pylib/gyp/generator/msvs.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py index 8fe9e5af23dd38..923e897e486f7c 100644 --- a/tools/gyp/pylib/gyp/generator/msvs.py +++ b/tools/gyp/pylib/gyp/generator/msvs.py @@ -2156,6 +2156,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies, A pair of (group this file should be part of, the label of element) """ _, ext = os.path.splitext(source) + ext = ext.lower() if ext in extension_to_rule_name: group = 'rule' element = extension_to_rule_name[ext] @@ -2168,7 +2169,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies, elif ext == '.rc': group = 'resource' element = 'ResourceCompile' - elif ext == '.asm': + elif ext in ['.s', '.asm']: group = 'masm' element = 'MASM' elif ext == '.idl':