From 78592a34c6aef85b9a84afe529835a8d931907cf Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 30 Nov 2017 07:46:03 +0100 Subject: [PATCH] test: make CreateParams stack-allocated PR-URL: https://github.com/nodejs/node/pull/17366 Reviewed-By: Anna Henningsen Reviewed-By: Timothy Gu Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis --- test/cctest/node_test_fixture.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h index bbc46986ebe922..d5be613c0bd105 100644 --- a/test/cctest/node_test_fixture.h +++ b/test/cctest/node_test_fixture.h @@ -61,7 +61,6 @@ class NodeTestFixture : public ::testing::Test { node::MultiIsolatePlatform* Platform() const { return platform_; } protected: - v8::Isolate::CreateParams params_; v8::Isolate* isolate_; ~NodeTestFixture() { @@ -73,6 +72,7 @@ class NodeTestFixture : public ::testing::Test { platform_ = new node::NodePlatform(8, nullptr); v8::V8::InitializePlatform(platform_); v8::V8::Initialize(); + v8::Isolate::CreateParams params_; params_.array_buffer_allocator = allocator_.get(); isolate_ = v8::Isolate::New(params_); }