From 7b0d8673898e65a368108264c77bccaa3e004028 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Wed, 10 Apr 2019 08:43:05 -0400 Subject: [PATCH] build: fix test failures not failing Travis builds The exit code of the make command used to execute tests was being lost after being piped through to grep. PR-URL: https://github.com/nodejs/node/pull/27176 Reviewed-By: Joyee Cheung Reviewed-By: Yongsheng Zhang Reviewed-By: Beth Griggs Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 576de336e2df11..5fe00ad55c03a7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -65,4 +65,5 @@ jobs: - make -j2 > /dev/null - make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null script: + - set -o pipefail - JOBS=2 FLAKY_TESTS=dontcare make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v