Skip to content

Commit

Permalink
test: update http test to use Countdown
Browse files Browse the repository at this point in the history
PR-URL: #17477
Refs: #17169
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information
onneri authored and MylesBorins committed Dec 12, 2017
1 parent 6aa6d41 commit 7b8622f
Showing 1 changed file with 8 additions and 17 deletions.
25 changes: 8 additions & 17 deletions test/parallel/test-http-status-code.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,45 +23,36 @@
require('../common');
const assert = require('assert');
const http = require('http');
const Countdown = require('../common/countdown');

// Simple test of Node's HTTP ServerResponse.statusCode
// ServerResponse.prototype.statusCode

let testsComplete = 0;
const tests = [200, 202, 300, 404, 451, 500];
let testIdx = 0;
let test;
const countdown = new Countdown(tests.length, () => s.close());

const s = http.createServer(function(req, res) {
const t = tests[testIdx];
res.writeHead(t, { 'Content-Type': 'text/plain' });
res.writeHead(test, { 'Content-Type': 'text/plain' });
console.log(`--\nserver: statusCode after writeHead: ${res.statusCode}`);
assert.strictEqual(res.statusCode, t);
assert.strictEqual(res.statusCode, test);
res.end('hello world\n');
});

s.listen(0, nextTest);


function nextTest() {
if (testIdx + 1 === tests.length) {
return s.close();
}
const test = tests[testIdx];
test = tests.shift();

http.get({ port: s.address().port }, function(response) {
console.log(`client: expected status: ${test}`);
console.log(`client: statusCode: ${response.statusCode}`);
assert.strictEqual(response.statusCode, test);
response.on('end', function() {
testsComplete++;
testIdx += 1;
nextTest();
if (countdown.dec())
nextTest();
});
response.resume();
});
}


process.on('exit', function() {
assert.strictEqual(5, testsComplete);
});

0 comments on commit 7b8622f

Please sign in to comment.