From 7cf79fa1c9cc8dd7bad2dac3258c4740b93dd3f3 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 13 Jun 2019 11:59:15 +0200 Subject: [PATCH] build: guard test-doc recipe with node_use_openssl Currently, when configuring --without-ssl the test-doc target fails with the following error: /node/test/common/index.js:707 const crashOnUnhandledRejection = (err) => { throw err; }; ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:97:11) at https.js:26:26 at NativeModule.compile (internal/bootstrap/loaders.js:300:5) ... at /node/tools/doc/versions.js:7:19 at new Promise () at getUrl (/node/tools/doc/versions.js:6:10) Command: out/Release/node /node/test/doctool/test-doctool-html.js [00:02|% 100|+ 3|- 1]: Done make: *** [test-doc] Error 1 This commit guards the test-doc recipe to not run if node was configured without crypto support. PR-URL: https://github.com/nodejs/node/pull/28199 Reviewed-By: Ben Noordhuis Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Rich Trott --- Makefile | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 860c27676c8854..e14edb2a034173 100644 --- a/Makefile +++ b/Makefile @@ -586,8 +586,12 @@ test-hash-seed: all .PHONY: test-doc test-doc: doc-only ## Builds, lints, and verifies the docs. - $(MAKE) lint - $(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC) + @if [ "$(shell $(node_use_openssl))" != "true" ]; then \ + echo "Skipping test-doc (no crypto)"; \ + else \ + $(MAKE) lint; \ + $(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC); \ + fi test-known-issues: all $(PYTHON) tools/test.py $(PARALLEL_ARGS) known_issues