Skip to content

Commit

Permalink
src: remove TLSEXT_TYPE_alpn guard
Browse files Browse the repository at this point in the history
TLSEXT_TYPE_application_layer_protocol_negotiation is always defined in
all supported OpenSSL versions. We also use this macro elsewhere without
guards, so if it did not exist, compilation would have already failed.

Besides that, it makes little sense to provide a TLS 1.3 implementation
that does not support ALPN.

PR-URL: #46956
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
tniessen authored and targos committed Mar 14, 2023
1 parent b051ac7 commit 815d2af
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/node_constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,8 @@ void DefineCryptoConstants(Local<Object> target) {
NODE_DEFINE_CONSTANT(target, DH_NOT_SUITABLE_GENERATOR);
#endif

#ifdef TLSEXT_TYPE_application_layer_protocol_negotiation
#define ALPN_ENABLED 1
NODE_DEFINE_CONSTANT(target, ALPN_ENABLED);
#endif

#ifdef RSA_PKCS1_PADDING
NODE_DEFINE_CONSTANT(target, RSA_PKCS1_PADDING);
Expand Down

0 comments on commit 815d2af

Please sign in to comment.