From 883281bca99bc4f3d1eec08d3f6a5b9ca6a11bfc Mon Sep 17 00:00:00 2001 From: buji Date: Tue, 14 Nov 2017 19:41:46 +0800 Subject: [PATCH] buffer: don't predefine error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/17021 Fixes: https://github.com/nodejs/node/issues/16994 Reviewed-By: Evan Lucas Reviewed-By: Gireesh Punathil Reviewed-By: Michaƫl Zasso Reviewed-By: Refael Ackermann Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Anatoli Papirovski Reviewed-By: Luigi Pinca --- lib/buffer.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index bbc2336e5d0bbb..8899d260ad29e0 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -449,14 +449,12 @@ Buffer.isEncoding = function isEncoding(encoding) { }; Buffer[kIsEncodingSymbol] = Buffer.isEncoding; -const kConcatErr = new errors.TypeError( - 'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array'] -); - Buffer.concat = function concat(list, length) { var i; if (!Array.isArray(list)) - throw kConcatErr; + throw new errors.TypeError( + 'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array'] + ); if (list.length === 0) return new FastBuffer(); @@ -474,7 +472,9 @@ Buffer.concat = function concat(list, length) { for (i = 0; i < list.length; i++) { var buf = list[i]; if (!isUint8Array(buf)) - throw kConcatErr; + throw new errors.TypeError( + 'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array'] + ); _copy(buf, buffer, pos); pos += buf.length; }