Skip to content

Commit

Permalink
test: allow for slow hosts in spawnSync() test
Browse files Browse the repository at this point in the history
test-child-process-spawnsync-timeout failed from time to time on
Raspberry Pi devices. Use common.platformTimeout() to allow a little
more time to run on resource-constrained hosts.

PR-URL: #10998
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Mar 9, 2017
1 parent 4d6fa8d commit 8ff15a2
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions test/parallel/test-child-process-spawnsync-timeout.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict';
require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

var spawnSync = require('child_process').spawnSync;

var TIMER = 200;
var SLEEP = 5000;
const TIMER = 200;
const SLEEP = common.platformTimeout(5000);

switch (process.argv[2]) {
case 'child':
Expand All @@ -19,8 +19,7 @@ switch (process.argv[2]) {
var ret = spawnSync(process.execPath, [__filename, 'child'],
{timeout: TIMER});
assert.strictEqual(ret.error.errno, 'ETIMEDOUT');
console.log(ret);
var end = Date.now() - start;
const end = Date.now() - start;
assert(end < SLEEP);
assert(ret.status > 128 || ret.signal);
break;
Expand Down

0 comments on commit 8ff15a2

Please sign in to comment.