Skip to content

Commit

Permalink
build: disable test-asan workflow
Browse files Browse the repository at this point in the history
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: #52374
Refs: #53651 (comment)
PR-URL: #53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
targos authored and marco-ippolito committed Aug 19, 2024
1 parent 8c8e368 commit 977af25
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test-asan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ permissions:

jobs:
test-asan:
if: github.event.pull_request.draft == false
if: false # Temporarily disabled. References: https://github.com/nodejs/node/pull/52374, https://github.com/nodejs/node/pull/53651#issuecomment-2198510810
runs-on: ubuntu-20.04
env:
CC: sccache clang
Expand Down

0 comments on commit 977af25

Please sign in to comment.