From 9eacd66bcb21d8e3faf667b5e77ff0f1352f4a9b Mon Sep 17 00:00:00 2001 From: Kyle Farnung Date: Fri, 20 Apr 2018 18:41:20 -0700 Subject: [PATCH] lib: make sure `console` is writable The code currently assumes that `console` is already writable, but that's only if it was previously defined as writable. If it hasn't already been defined then the default value is false. Refs: https://github.com/nodejs/node/pull/17708 PR-URL: https://github.com/nodejs/node/pull/20185 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell --- lib/internal/bootstrap/node.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index 7762aac84691d6..f9bed03d269fb2 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -356,7 +356,8 @@ Object.defineProperty(global, 'console', { configurable: true, enumerable: false, - value: wrappedConsole + value: wrappedConsole, + writable: true }); setupInspector(originalConsole, wrappedConsole, CJSModule); }