lib: move queueMicrotask to stable

PR-URL: #25594 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
nodejs · Mar 8, 2019 · 9f1282d · 9f1282d
1 parent b05fd4b
commit 9f1282d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 26 deletions.
diff --git a/doc/api/globals.md b/doc/api/globals.md
@@ -114,8 +114,6 @@ added: v11.0.0
 
 <!-- type=global -->
 
-> Stability: 1 - Experimental
-
 * `callback` {Function} Function to be queued.
 
 The `queueMicrotask()` method queues a microtask to invoke `callback`. If

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -396,30 +396,12 @@ function createGlobalConsole(consoleFromVM) {
 }
 
 function setupQueueMicrotask() {
+  const { queueMicrotask } =
+    NativeModule.require('internal/queue_microtask');
   Object.defineProperty(global, 'queueMicrotask', {
-    get() {
-      process.emitWarning('queueMicrotask() is experimental.',
-                          'ExperimentalWarning');
-      const { queueMicrotask } =
-        NativeModule.require('internal/queue_microtask');
-
-      Object.defineProperty(global, 'queueMicrotask', {
-        value: queueMicrotask,
-        writable: true,
-        enumerable: false,
-        configurable: true,
-      });
-      return queueMicrotask;
-    },
-    set(v) {
-      Object.defineProperty(global, 'queueMicrotask', {
-        value: v,
-        writable: true,
-        enumerable: false,
-        configurable: true,
-      });
-    },
-    enumerable: false,
+    value: queueMicrotask,
+    writable: true,
+    enumerable: true,
     configurable: true,
   });
 }

diff --git a/test/common/index.js b/test/common/index.js
@@ -258,7 +258,8 @@ let knownGlobals = [
   global,
   setImmediate,
   setInterval,
-  setTimeout
+  setTimeout,
+  queueMicrotask,
 ];
 
 if (global.gc) {

diff --git a/test/parallel/test-global.js b/test/parallel/test-global.js
@@ -43,6 +43,7 @@ builtinModules.forEach((moduleName) => {
 {
   const expected = [
     'global',
+    'queueMicrotask',
     'clearImmediate',
     'clearInterval',
     'clearTimeout',