From b015747156fdcbfdb970935bda74f601b37d6a6a Mon Sep 17 00:00:00 2001 From: Guy Bedford Date: Wed, 29 Nov 2017 10:58:11 +0200 Subject: [PATCH] doc: esm loader example with module.builtinModules MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/17385 Reviewed-By: Michaƫl Zasso Reviewed-By: Colin Ihrig Reviewed-By: Jon Moss Reviewed-By: Timothy Gu --- doc/api/esm.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/doc/api/esm.md b/doc/api/esm.md index c352c24aa1c56d..b812d7cb76db0b 100644 --- a/doc/api/esm.md +++ b/doc/api/esm.md @@ -147,15 +147,13 @@ be written: import url from 'url'; import path from 'path'; import process from 'process'; +import Module from 'module'; -const builtins = new Set( - Object.keys(process.binding('natives')).filter((str) => - /^(?!(?:internal|node|v8)\/)/.test(str)) -); +const builtins = Module.builtinModules; const JS_EXTENSIONS = new Set(['.js', '.mjs']); export function resolve(specifier, parentModuleURL/*, defaultResolve */) { - if (builtins.has(specifier)) { + if (builtins.includes(specifier)) { return { url: specifier, format: 'builtin'