test: fix long-running buffer benchmarks

PR-URL: #20125 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Apr 23, 2018 · c61db33 · c61db33
1 parent 2883454
commit c61db33
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/benchmark/buffers/buffer-base64-decode-wrapped.js b/benchmark/buffers/buffer-base64-decode-wrapped.js
@@ -3,12 +3,12 @@
 const common = require('../common.js');
 
 const bench = common.createBenchmark(main, {
+  charsPerLine: [76],
+  linesCount: [8 << 16],
   n: [32],
 });
 
-function main({ n }) {
-  const charsPerLine = 76;
-  const linesCount = 8 << 16;
+function main({ charsPerLine, linesCount, n }) {
   const bytesCount = charsPerLine * linesCount / 4 * 3;
 
   const line = `${'abcd'.repeat(charsPerLine / 4)}\n`;

diff --git a/benchmark/buffers/buffer-base64-decode.js b/benchmark/buffers/buffer-base64-decode.js
@@ -4,10 +4,11 @@ const common = require('../common.js');
 
 const bench = common.createBenchmark(main, {
   n: [32],
+  size: [8 << 20]
 });
 
-function main({ n }) {
-  const s = 'abcd'.repeat(8 << 20);
+function main({ n, size }) {
+  const s = 'abcd'.repeat(size);
   // eslint-disable-next-line node-core/no-unescaped-regexp-dot
   s.match(/./);  // Flatten string.
   assert.strictEqual(s.length % 4, 0);

diff --git a/benchmark/buffers/buffer-indexof.js b/benchmark/buffers/buffer-indexof.js
@@ -25,10 +25,10 @@ const bench = common.createBenchmark(main, {
   search: searchStrings,
   encoding: ['undefined', 'utf8', 'ucs2', 'binary'],
   type: ['buffer', 'string'],
-  iter: [100000]
+  n: [100000]
 });
 
-function main({ iter, search, encoding, type }) {
+function main({ n, search, encoding, type }) {
   var aliceBuffer = fs.readFileSync(
     path.resolve(__dirname, '../fixtures/alice.html')
   );
@@ -46,8 +46,8 @@ function main({ iter, search, encoding, type }) {
   }
 
   bench.start();
-  for (var i = 0; i < iter; i++) {
+  for (var i = 0; i < n; i++) {
     aliceBuffer.indexOf(search, 0, encoding);
   }
-  bench.end(iter);
+  bench.end(n);
 }
diff --git a/test/sequential/test-benchmark-buffer.js b/test/sequential/test-benchmark-buffer.js
@@ -10,9 +10,11 @@ runBenchmark('buffers',
                'args=1',
                'buffer=fast',
                'byteLength=1',
+               'charsPerLine=6',
                'encoding=utf8',
                'endian=BE',
                'len=2',
+               'linesCount=1',
                'method=',
                'n=1',
                'pieces=1',