Skip to content

Commit

Permalink
build: allow running configure from any directory
Browse files Browse the repository at this point in the history
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
gibfahn authored and MylesBorins committed Dec 12, 2017
1 parent 510116e commit dcb53c1
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,23 @@ import subprocess
import shutil
import string

# If not run from node/, cd to node/.
os.chdir(os.path.dirname(__file__) or '.')

# gcc and g++ as defaults matches what GYP's Makefile generator does,
# except on OS X.
CC = os.environ.get('CC', 'cc' if sys.platform == 'darwin' else 'gcc')
CXX = os.environ.get('CXX', 'c++' if sys.platform == 'darwin' else 'g++')

root_dir = os.path.dirname(__file__)
sys.path.insert(0, os.path.join(root_dir, 'tools', 'gyp', 'pylib'))
sys.path.insert(0, os.path.join('tools', 'gyp', 'pylib'))
from gyp.common import GetFlavor

# imports in tools/configure.d
sys.path.insert(0, os.path.join(root_dir, 'tools', 'configure.d'))
sys.path.insert(0, os.path.join('tools', 'configure.d'))
import nodedownload

# imports in tools/
sys.path.insert(0, os.path.join(root_dir, 'tools'))
sys.path.insert(0, 'tools')
import getmoduleversion
from gyp_node import run_gyp

Expand Down Expand Up @@ -432,7 +434,7 @@ intl_optgroup.add_option('--download',
intl_optgroup.add_option('--download-path',
action='store',
dest='download_path',
default=os.path.join(root_dir, 'deps'),
default='deps',
help='Download directory [default: %default]')

parser.add_option_group(intl_optgroup)
Expand Down Expand Up @@ -1046,7 +1048,7 @@ def configure_openssl(o):
o['defines'] += ['NODE_WITHOUT_NODE_OPTIONS']
if options.openssl_fips:
o['variables']['openssl_fips'] = options.openssl_fips
fips_dir = os.path.join(root_dir, 'deps', 'openssl', 'fips')
fips_dir = os.path.join('deps', 'openssl', 'fips')
fips_ld = os.path.abspath(os.path.join(fips_dir, 'fipsld'))
# LINK is for Makefiles, LD/LDXX is for ninja
o['make_fips_settings'] = [
Expand Down Expand Up @@ -1091,7 +1093,7 @@ def configure_static(o):


def write(filename, data):
filename = os.path.join(root_dir, filename)
filename = filename
print('creating %s' % filename)
f = open(filename, 'w+')
f.write(data)
Expand Down Expand Up @@ -1213,7 +1215,7 @@ def configure_intl(o):
return

# this is just the 'deps' dir. Used for unpacking.
icu_parent_path = os.path.join(root_dir, 'deps')
icu_parent_path = 'deps'

# The full path to the ICU source directory. Should not include './'.
icu_full_path = 'deps/icu'
Expand Down

0 comments on commit dcb53c1

Please sign in to comment.