From f7aa22a0ebc089fdafbe2c56d4f8b9b495c02611 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 3 Jul 2018 15:55:33 -0700 Subject: [PATCH] doc: improve guide text for CI runs Make the text about CI runs in the COLLABORATOR_GUIDE more concise. Add information about Resume Build which should generally be preferred over Rebuild. PR-URL: https://github.com/nodejs/node/pull/21645 Reviewed-By: Gus Caplan Reviewed-By: Trivikram Kamat Reviewed-By: Luigi Pinca Reviewed-By: Vse Mozhet Byt --- COLLABORATOR_GUIDE.md | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 238a72547247b6..8d50589afdd11d 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -199,14 +199,10 @@ status indicator. Do not land any Pull Requests without passing (green or yellow) CI runs. If you believe any failed (red or grey) CI sub-tasks are unrelated to the change in the -Pull Request, you may re-run the sub-task to try to see if it passes (just open -the failed sub-task page and press the "Rebuild" button; be sure you are still -logged in for this action). If re-runs of all failed sub-tasks pass (do not -forget to provide the links for successfully rerun sub-tasks), it is permissible -to land the Pull Request but only if the initial failures are believed in good -faith to be unrelated to the changes in the Pull Request. Otherwise, reasonable -steps must be taken to confirm that the changes are not resulting in an -unreliable test. +Pull Request, use "Resume Build" in the left navigation of the relevant +`node-test-pull-request` job. It will create a new `node-test-pull-request` run +that preserves all the green results from the current job but re-runs everything +else. #### Useful CI Jobs