Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v1.5.0 #1060

Closed
rvagg opened this issue Mar 4, 2015 · 25 comments
Closed

Release proposal: v1.5.0 #1060

rvagg opened this issue Mar 4, 2015 · 25 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Mar 4, 2015

Lots of stuff has landed, we have the new Buffer#indexOf() and I see a bunch of stuff on the verge of landing too--which may make it in to this release if we give it a couple of days. I'm calling 48 hours (approx) on this release.

Again it'd be nice to have attention on #1005 if we can have some @iojs/platform-windows people (or non-Windows people even! It shouldn't be that hard) to focus on some fixes to reduce the error count.

  • [b27931b0fe] - benchmark: fix wrk check (Brian White) #1076
  • [2b79052494] - benchmark: check for wrk ahead of running benchmarks (Johan Bergström) #982
  • [31421afe89] - buffer: reword Buffer.concat error message (Chris Dickinson) joyent/node#8723
  • [78581c8d90] - (SEMVER-MINOR) buffer: add indexOf() method (Trevor Norris) #561
  • [37bb1df7c4] - build: remove mdb from io.js (Johan Bergström) #1023
  • [726671cb0e] - build: add basic mips/mipsel support (Ben Noordhuis) #1045
  • [a45d4f8fd6] - build: remove tools/wrk from the tree (Johan Bergström) #982
  • [dee07e2983] - deps: make node-gyp work with io.js (cjihrig) #990
  • [fe14802fb7] - deps: upgrade npm to 2.7.0 (Forrest L Norvell) #1080
  • [31142415de] - doc: add TC meeting 2015-02-18 minutes (Rod Vagg) #1051
  • [6190a2236b] - doc: remove cjihrig from TC (cjihrig) #1056
  • [9741291fe9] - doc: fix child_process heading depth (Sam Roberts) #1038
  • [c8110692a5] - doc: add explanations for querystring (Robert Kowalski) joyent/node#9259
  • [8fb711e06c] - doc: fix default value of opts.decodeURIComponent (h7lin) joyent/node#9259
  • [6433ad1eef] - doc: add missing newline in CHANGELOG (Rod Vagg)
  • [555a7c48cf] - events: optimize listener array cloning (Brian White) #1050
  • [4d0329ebeb] - (SEMVER-MINOR) fs: remove unnecessary usage of .hasOwnProperty() (Jonathan Ong) #635
  • [4874182065] - http: send Content-Length when possible (Christian Tellnes) #1062
  • [08133f45c7] - http: optimize outgoing requests (Brendan Ashworth) #605
  • [dccb69a21a] - js_stream: fix leak of instances (Fedor Indutny) #1078
  • [4ddd6406ce] - lib: avoid .toLowerCase() call in Buffer#write() (Ben Noordhuis) #1048
  • [bbf54a554a] - lib: hand-optimize Buffer constructor (Ben Noordhuis) #1048
  • [9d2b89d06c] - net: allow port 0 in connect() (cjihrig) joyent/node#9268
  • [e0835c9cda] - node: improve performance of nextTick (Trevor Norris) #985
  • [8f5f12bb48] - smalloc: export constants from C++ (Vladimir Kurchatkin) #920
  • [0697f8b44d] - smalloc: validate arguments in js (Vladimir Kurchatkin) #920
  • [1640dedb3b] - src: fix ucs-2 buffer encoding regression (Ben Noordhuis) #1042
  • [2eda2d6096] - src: fix external string length calculation (Ben Noordhuis) #1042
  • [4aea16f214] - src: rename confusingly named local variable (Ben Noordhuis) #1042
  • [c9ee654290] - src: simplify node::Utf8Value() (Ben Noordhuis) #1042
  • [364cc7e08a] - src: remove NODE_INVALID_UTF8 environment variable (Ben Noordhuis) #1042
  • [826cde8661] - src: fix gc heuristic for external twobyte strings (Ben Noordhuis) #1042
  • [f5b7e18243] - src: remove unused code (Ben Noordhuis) #1042
  • [4ae64b2626] - src: extract node env init out of process init (Petka Antonov) #980
  • [b150c9839e] - src: fix -Wempty-body compiler warnings (Ben Noordhuis) #974
  • [fb284e2e4d] - src: fix compiler warning in smalloc.cc (Ben Noordhuis) #1055
  • [583a868bcd] - stream_wrap: add HandleScope's in uv callbacks (Fedor Indutny) #1078
  • [e2fb733a95] - test: simplify parallel/test-stringbytes-external (Ben Noordhuis) #1042
  • [7b554b1a8f] - test: don't spawn child processes in domain test (Ben Noordhuis) #974
  • [b72fa03057] - test: adds a test for undefined value in setHeader (Ken Perkins) #970
  • [563771d8b1] - test: split parts out of host-headers test into its own test (Johan Bergström) #1049
  • [671fbd5a9d] - test: refactor all tests that depends on crypto (Johan Bergström) #1049
  • [c7ad320472] - test: check for openssl cli and provide path if it exists (Johan Bergström) #1049
  • [71776f9057] - test: remove unused https imports (Johan Bergström) #1049
  • [3d5726c4ad] - test: introduce a helper that checks if crypto is available (Johan Bergström) #1049
  • [d0e7c359a7] - test: don't assume process.versions.openssl always is available (Johan Bergström) #1049
  • [e1bf6709dc] - test: fix racey-ness in tls-inception (Fedor Indutny) #1040
  • [fd3ea29902] - test: fix test-fs-access when uid is 0 (Johan Bergström) #1037
  • [5abfa930b8] - test: make destroyed-socket-write2.js more robust (Michael Dawson) joyent/node#9270
  • [1009130495] - tests: fix race in test-http-curl-chunk-problem (Julien Gilli)
  • [bd1bd7e38d] - timer: Improve performance of callbacks (Ruben Verborgh) #406
  • [7b3b8acfa6] - tls: accept empty net.Sockets (Fedor Indutny) #1046
  • [c09c90c1a9] - tls_wrap: do not hold persistent ref to parent (Fedor Indutny) #1078
  • [3446ff417b] - tty: do not add shutdown method to handle (Fedor Indutny) #1073
  • [abb00cc915] - url: throw for invalid values to url.format (Christian Tellnes) #1036
  • [abd3ecfbd1] - win,test: fix test-stdin-from-file (Bert Belder)
@rvagg
Copy link
Member Author

rvagg commented Mar 5, 2015

that escalated quickly

commit log doubled overnight

@Fishrock123
Copy link
Contributor

:shipit:

win,test: fix test-stdin-from-file (Bert Belder)

Guessing the commit tool does not parse multiple subsystems?

@rvagg
Copy link
Member Author

rvagg commented Mar 5, 2015

Guessing the commit tool does not parse multiple subsystems?

Yeah, it does as of changelog-maker@1.2.1, fixed it just after updating here, I've updated again with the new output.

@rvagg
Copy link
Member Author

rvagg commented Mar 5, 2015

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/246/

Current v1.x, with expected failures and still ~8 failures for Windows.

@Starefossen
Copy link
Member

giphy

Excited!

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

https://iojs.org/download/nightly/v1.4.4-nightly20150305b27931b0fe/

consider that an RC, we'll roll another one tomorrow before release build

@qfox
Copy link

qfox commented Mar 6, 2015

I need nighty build to make test cases for win. Not sure how to install the latest version from sources.

Oops. Sorry. https://iojs.org/download/nightly/

@Fishrock123
Copy link
Contributor

@zxqfox there are both .msi installers there and windows binaries in the folders at the top. :)

@Fishrock123
Copy link
Contributor

If possible, #1080 (npm@2.7.0) and #1078 (tls mem leak fix) (both landed) would be good to make it into this.

@qfox
Copy link

qfox commented Mar 6, 2015

Just fyi: I can't repeat errors with the current v1.4.4-nightly20150305b27931b0fe, that's great ;-)

@Fishrock123 Yeah, by mad. ;-)

@Fishrock123
Copy link
Contributor

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/250/ -- looks like the test for #1068 is (still / again) failing on windows.

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

at this stage I'm not going to let existing errors on Windows hold up on a release but we should definitely be on a path towards reducing the number of errors

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

https://iojs.org/download/nightly/v1.4.4-nightly20150306dee07e2983/

RC just now with a bunch of new stuff in it including the (hopeful) TLSWrap leak fixes reported in #1075. Please test.

@snostorm
Copy link

snostorm commented Mar 6, 2015

Ping @iojs/website that we're close to a new release. I'll stalk this thread myself for the next few hours.

@therebelrobot
Copy link

Stalking as well. @snostorm, lemme know if we need time on this, I'll hop in this afternoon.

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

@iojs/collaborators because of the pace of development I'm calling a freeze on code merges until 1.5.0 lands please. Only merge changes in this period if they:

  • are trivial and unlikely to have an impact on the operation of Node
  • are doc: or benchmark:
  • are test: and are lightweight

If you want to merge something before 1.5.0 gets out please discuss it here!

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

2015-03-06, Version 1.5.0, @rvagg

Notable changes

  • buffer: New Buffer#indexOf() method, modelled off Array#indexOf(). Accepts a String, Buffer or a Number. Strings are interpreted as UTF8. (Trevor Norris) #561
  • fs: options object properties in 'fs' methods no longer perform a hasOwnProperty() check, thereby allowing options objects to have prototype properties that apply. (Jonathan Ong) #635
  • tls: A likely TLS memory leak was reported by PayPal. Some of the recent changes in stream_wrap appear to be to blame. The initial fix is in #1078, you can track the progress toward closing the leak at #1075 (Fedor Indutny).
  • npm: Upgrade npm to 2.7.0. See npm CHANGELOG.md for details including why this is a semver-minor when it could have been semver-major. Summary:
    • 145af65
      #4887 Replace calls to the
      node-gyp script bundled with npm by passing the
      --node-gyp=/path/to/node-gyp option to npm. Swap in pangyp or a version
      of node-gyp modified to work better with io.js without having to touch
      npm's code! (@ackalker)
    • 2f6a1df
      #1999 Only run stop and start
      scripts (plus their pre- and post- scripts) when there's no restart script
      defined. This makes it easier to support graceful restarts of services
      managed by npm. (@watilde /
      @scien)
    • 448efd0
      #2853 Add support for --dev and
      --prod to npm ls, so that you can list only the trees of production or
      development dependencies, as desired.
      (@watilde)
    • a0a8777
      #7463 Split the list printed by
      npm run-script into lifecycle scripts and scripts directly invoked via npm run-script. (@watilde)
    • a5edc17
      #6749 init-package-json@1.3.1:
      Support for passing scopes to npm init so packages are initialized as part
      of that scope / organization / team. (@watilde)
  • TC: Colin Ihrig (@cjihrig) resigned from the TC due to his desire to do more code and fewer meetings.

Known issues

  • Windows still reports some minor test failures and we are continuing to address all of these ASAP. See #1005.
  • Surrogate pair in REPL can freeze terminal #690
  • Not possible to build io.js as a static library #686
  • process.send() is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760 and fix in #774
  • Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion #894

Commits

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

tagged v1.5.0 @ 25a7fc8

building @ https://jenkins-iojs.nodesource.com/job/iojs+release/44/

@rosskukulinski
Copy link

@rvagg could you copy/paste the release notes markdown in raw form to nodejs/evangelism#16?

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

@rosskukulinski same notes are in the CHANGELOG.md in v1.x now, grab from there

@Fishrock123
Copy link
Contributor

I have a website update ready when they go live in /dist/

@rvagg
Copy link
Member Author

rvagg commented Mar 6, 2015

done & released @ https://iojs.org/dist/latest/

thanks all

@rvagg rvagg closed this as completed Mar 6, 2015
@Fishrock123
Copy link
Contributor

Site is updated -- https://iojs.org Cheers! 🍻

@rosskukulinski
Copy link

👍 Have a great weekend folks.

@therebelrobot
Copy link

Spectacular, everyone. High fives all around.

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

8 participants