Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why node doesn't use cmake as a build tool ? #12088

Closed
benmouh opened this issue Mar 28, 2017 · 5 comments
Closed

Why node doesn't use cmake as a build tool ? #12088

benmouh opened this issue Mar 28, 2017 · 5 comments
Labels
build Issues and PRs related to build files or the CI. question Issues that look for answers.

Comments

@benmouh
Copy link

benmouh commented Mar 28, 2017

  • all Version:
  • Cross Platform:
  • Subsystem:

Why node doesn't use cmake as a build tool instead of using a GYP script ?

@hiroppy hiroppy added build Issues and PRs related to build files or the CI. question Issues that look for answers. labels Mar 28, 2017
@bnoordhuis
Copy link
Member

Because we use GYP.

@benmouh
Copy link
Author

benmouh commented Mar 28, 2017

@bnoordhuis right ! what's the advantages so of using GYP as a build tool

@bnoordhuis
Copy link
Member

I'd summarize it as "it works." The effort we sunk into it to get to that point means a switch to another build system is unlikely.

@GauthamBanasandra
Copy link
Contributor

@bnoordhuis are there any ongoing efforts/plan to switch from gyp to CMake? I've a fairly good knowledge of CMake and would love to help.
Had CMake been used here, there wouldn't have been issues like this - #27214 (across platforms too).

@bnoordhuis
Copy link
Member

@GauthamBanasandra Ongoing? No. I made an attempt in https://github.com/bnoordhuis/io.js/tree/cmake but chasing a moving target is difficult. You're welcome to dust it off though.

Had CMake been used here, there wouldn't have been issues like this - #27214 (across platforms too).

Maybe not, but there will no doubt be other issues. For example, nodejs/node-gyp#1118 is something you'll need to contend with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

4 participants