Internal error in node-inspect. Please report this bug.

[avaer]

Just running node debug . tells me to report this bug. There doesn't need to be any actual module to run.

I think it's harmless and just complaining about the used port. But node explicitly told me to report this bug, so I'm following the instructions given 👍.

• Version: v9.7.1
• Platform: Windows 10 x64
• Subsystem: node-inspect

node debug .
(node:14108) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead.
There was an internal error in node-inspect. Please report this bug.
Timeout (2000) waiting for 127.0.0.1:9229 to be free
Error: Timeout (2000) waiting for 127.0.0.1:9229 to be free
    at Timeout.setTimeout [as _onTimeout] (node-inspect/lib/_inspect.js:54:14)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:267:5)

[Trott]

/ping @jkrems

[bnoordhuis]

The 'internal error' message looks like a red herring to me, the real error is fairly benign: port 9229 is taken, probably by another node process.

[jkrems]

Thanks for the report! Yeah, this seems silly (agreed with @bnoordhuis that it just seems to be the blocked port, not an actual bug) and we should fix the output for this case.

[LEQADA]

I was thinking maybe we can add error.code = 'ECONNRESET'; to this error and in the handling function do something like this

    if(e.code !== 'ECONNRESET')
      console.error('There was an internal error in node-inspect. ' +
                    'Please report this bug.');

@jkrems @bnoordhuis wdyt ?

[LEQADA]

Ping @jkrems @bnoordhuis. I can create a PR if you agree.

[bnoordhuis]

@LEQADA Hm, that feels a little too much like a hack to me. Would logging a message followed by process.exit(1) in the timer callback work?

Note that a PR should go to nodejs/node-inspect. Once merged, it will make its way here on the next update.

[jkrems]

Alternatively: making it a non-fatal error. "Failed to start app. Please check that the port isn't used by anything else. Use run to try again." etc.. Another solution would be to use a custom code and/or error class (StartupError) and exclude that from the internal error message. But that seems a bit more hacky.

[LEQADA]

I duplicated this issue to the node-inspect repo. Should we move the discussion there?
nodejs/node-inspect#60

[jkrems]

Moving discussion to node-inspect since that's where the issue needs to be resolved.