Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 8.14.0 keep-alive request fails #24880

Closed
kangman opened this issue Dec 6, 2018 · 1 comment
Closed

Node 8.14.0 keep-alive request fails #24880

kangman opened this issue Dec 6, 2018 · 1 comment
Labels
http Issues or PRs related to the http subsystem. invalid Issues and PRs that are invalid.

Comments

@kangman
Copy link

kangman commented Dec 6, 2018

using the example provided in #24760

within a single telnet session I get the same issue with connection being closed

telnet 172.16.18.128 4050
Trying 172.16.18.128...
Connected to 172.16.18.128.
Escape character is '^]'.

GET / HTTP/1.1
Connection: keep-alive
GET / HTTP/1.1
Connection: keep-aliveConnection closed by foreign host.

the second request being made 10 seconds after

same issue where the connection is closed right after sending the first line of the second HTTP request

@bnoordhuis
Copy link
Member

You're not making a valid request. Headers don't end until there's a blank line (\r\n).

In your example, the second GET / HTTP/1.1 is parsed as a malformed header (because it is.)

@bnoordhuis bnoordhuis added invalid Issues and PRs that are invalid. http Issues or PRs related to the http subsystem. labels Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. invalid Issues and PRs that are invalid.
Projects
None yet
Development

No branches or pull requests

2 participants