Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--enable-source-maps does not work in worker_threads #34898

Closed
cspotcode opened this issue Aug 24, 2020 · 5 comments
Closed

--enable-source-maps does not work in worker_threads #34898

cspotcode opened this issue Aug 24, 2020 · 5 comments
Labels
worker Issues and PRs related to Worker support.

Comments

@cspotcode
Copy link

  • Version: v14.8.0
  • Platform: Linux (Ubuntu)
  • Subsystem: worker_threads and source-maps

What steps will reproduce the bug?

Here is a complete, minimal reproduction executed on Github Actions.
https://github.com/cspotcode/repros/tree/node-source-map-worker-thread

  1. Create a worker_thread
  2. In the worker_thread, execute a .js file with a sourcemap.
  3. Log new Error().stack within the worker_thread. See that the stack does not have sourcemap information.
  4. Run exactly the same code in the main thread to see that the stack has sourcemap information, proving that the sourcemap is valid.

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

Sourcemap information is included in a stack trace within a worker_thread if that information is included in the stack traces in the main thread.

What do you see instead?

Worker thread stacks do not include sourcemap information even though main thread stacks do.

Additional information

@Leko Leko added the worker Issues and PRs related to Worker support. label Aug 29, 2020
@Leko
Copy link
Contributor

Leko commented Aug 30, 2020

This problem seems to be fixed on the master branch. But it's not fixed on the latest release(v14.9.0).

@Hashbrown777
Copy link

Still broken in v14.16.0, even explicitly setting execArgv doesn't help.

@deftomat
Copy link

Works in 14.17.3

@Hashbrown777
Copy link

Can confirm, 14.17.3 became available on CentOS 8, and no longer exhibits the problem.

@targos
Copy link
Member

targos commented Aug 29, 2021

I'll close, assuming this is fixed. Feel free to ask to reopen if it's not the case.

@targos targos closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worker Issues and PRs related to Worker support.
Projects
None yet
Development

No branches or pull requests

5 participants