Proposal: HTTP – Move bodyHead to data event

[ThisIsMissEm]

So, ages and ages ago, for WebSockets support, the idea of an upgradeHead was added. This is for the data that directly trails the headers in a Upgrade or Connect request. Whilst the spec doesn't really say what this is, I propose making this as the first data event, rather than as a extra argument to the upgrade or connect events.

This seems like the better way to do this, although, I know it'd be a huge change in API from what we currently have, which is fairly popularly used at present.

I feel that we should've really implemented it this way round in the first place, but there were a whole bunch of reasons as to why this proved difficult at the time.

Thoughts?

[edef1c]

a40133d basically tried to fix this, resulting in nodejs/node-v0.x-archive#5557

[ThisIsMissEm]

Aye, I was talking to nathan when I created this ticket, it would indeed be a breaking change, it would hurt, but it'd mean a more consistent API.

– Micheil

On 22 Jan 2015, at 05:37, Nathan Zadoks notifications@github.com wrote:

https://github.com/joyent/node/commits/a40133d10cdb911b27fe8d46d67a835b0103bbf1 basically tried to fix this, resulting in nodejs/node-v0.x-archive#5557

—
Reply to this email directly or view it on GitHub.

[edef1c]

I'd definitely like to see this fixed — I think this legacy cruft has lived for long enough. I'd have vetoed the original node revert if I could.

[stephank]

Relevant (but old) node.js issue/pr: nodejs/node-v0.x-archive#3036

[Fishrock123]

Maybe also related to nodejs/node-v0.x-archive#4813

[stuartpb]

@miksago How does this relate to nodejs/node-v0.x-archive#4813? Does one override the necessity of the other?

[ThisIsMissEm]

I think nodejs/node-v0.x-archive#4813 closes this nicely.

[Fishrock123]

Actually it would be better if this were to close the joyent/node issue. :)

[jasnell]

Is this still something we'd want to do?

[jasnell]

Unfortunately, given the lack of any further discussion or action on this, I'm going to close. We can reopen and revisit later if necessary.