Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.ClientRequest documentation inconsistencies #5717

Closed
mrgleba opened this issue Mar 15, 2016 · 6 comments
Closed

http.ClientRequest documentation inconsistencies #5717

mrgleba opened this issue Mar 15, 2016 · 6 comments
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@mrgleba
Copy link

mrgleba commented Mar 15, 2016

The documentation for http.ClientRequest states that you can use
setHeader / getHeader / removeHeader but the motheds are not listed below
as methods of this class.

Method addTrailers is also not mentioned although it's there ans it's working.

@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Mar 15, 2016
@benjamingr
Copy link
Member

Would you be interested in submitting a pull request for fixing it @mrgleba ?

(If you have any questions about the technical parts of the process we can gladly help you with that)

@mrgleba
Copy link
Author

mrgleba commented Mar 15, 2016

Will do :)

@ghost
Copy link

ghost commented Mar 15, 2016

I honestly have no clue what that means

@mrgleba
Copy link
Author

mrgleba commented Mar 15, 2016

It means that I will prepare the pull request soon.

@mrgleba
Copy link
Author

mrgleba commented Mar 15, 2016

Done:
#5719

@jasnell
Copy link
Member

jasnell commented May 30, 2017

Appears to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants