From 1ed311e5d9ce9ab5a08054b3ca4e44e4e6eed43a Mon Sep 17 00:00:00 2001 From: fatahn Date: Tue, 27 Mar 2018 11:21:05 +0300 Subject: [PATCH 1/3] Change the string to a template literal to request done/sent values --- test/parallel/test-http-client-timeout-agent.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-http-client-timeout-agent.js b/test/parallel/test-http-client-timeout-agent.js index 2779c21394ae44..11fc1c3a0edaa1 100644 --- a/test/parallel/test-http-client-timeout-agent.js +++ b/test/parallel/test-http-client-timeout-agent.js @@ -92,5 +92,10 @@ server.listen(0, options.host, function() { process.on('exit', function() { console.error(`done=${requests_done} sent=${requests_sent}`); assert.strictEqual(requests_done, requests_sent, - 'timeout on http request called too much'); + ` + timeout on http request called too much. + requests_done: ${requests_done}, + requests_sent: ${requests_sent} + ` + ); }); From 70f8f730413a781ff0f01990579b7371ef11f1e4 Mon Sep 17 00:00:00 2001 From: fatahn Date: Tue, 27 Mar 2018 11:21:05 +0300 Subject: [PATCH 2/3] test: improve assert.strictEqual() with response_done & response_sent --- test/parallel/test-http-client-timeout-agent.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-http-client-timeout-agent.js b/test/parallel/test-http-client-timeout-agent.js index 2779c21394ae44..11fc1c3a0edaa1 100644 --- a/test/parallel/test-http-client-timeout-agent.js +++ b/test/parallel/test-http-client-timeout-agent.js @@ -92,5 +92,10 @@ server.listen(0, options.host, function() { process.on('exit', function() { console.error(`done=${requests_done} sent=${requests_sent}`); assert.strictEqual(requests_done, requests_sent, - 'timeout on http request called too much'); + ` + timeout on http request called too much. + requests_done: ${requests_done}, + requests_sent: ${requests_sent} + ` + ); }); From b891f55cf064d62281327a35b7462e6f78603d86 Mon Sep 17 00:00:00 2001 From: fatahn Date: Wed, 28 Mar 2018 20:51:19 +0300 Subject: [PATCH 3/3] Make message to a comment and omit the message parameter entirely --- test/parallel/test-http-client-timeout-agent.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-http-client-timeout-agent.js b/test/parallel/test-http-client-timeout-agent.js index 11fc1c3a0edaa1..bf00649edd6a25 100644 --- a/test/parallel/test-http-client-timeout-agent.js +++ b/test/parallel/test-http-client-timeout-agent.js @@ -91,11 +91,6 @@ server.listen(0, options.host, function() { process.on('exit', function() { console.error(`done=${requests_done} sent=${requests_sent}`); - assert.strictEqual(requests_done, requests_sent, - ` - timeout on http request called too much. - requests_done: ${requests_done}, - requests_sent: ${requests_sent} - ` - ); + // check that timeout on http request was not called too much + assert.strictEqual(requests_done, requests_sent); });