From d18d7767a408ab21aeb0694bda38e90e06eaf82c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 29 Apr 2018 20:26:29 -0700 Subject: [PATCH] doc: remove "has been known" tentativeness Remove unnecessary "has been known to" tentativeness from COLLABORATOR_GUIDE.md. "has been known to" is an awkward replacement for "can" or "might" or "sometimes does" or "does". Pick the right one and use it. --- COLLABORATOR_GUIDE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index a7b1e68d7276a9..89c532e9d025f5 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -489,8 +489,7 @@ The TSC should serve as the final arbiter where required. 1. Never use GitHub's green ["Merge Pull Request"][] button. Reasons for not using the web interface button: * The merge method will add an unnecessary merge commit. - * The squash & merge method has been known to add metadata to the commit - title (the PR #). + * The squash & merge method can add metadata (the PR #) to the commit title. * If more than one author has contributed to the PR, keep the most recent author when squashing. 1. Make sure the CI is done and the result is green. If the CI is not green,