From 390c6b84da4fd6732e1703d90a53d2d82f4cc3a3 Mon Sep 17 00:00:00 2001 From: Bryan English Date: Wed, 23 Feb 2022 19:04:44 -0500 Subject: [PATCH 1/2] doc: add release key for Bryan English MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds Bryan English and his public key to the README for releases. PR-URL: https://github.com/nodejs/node/pull/42102 Reviewed-By: Colin Ihrig Reviewed-By: Beth Griggs Reviewed-By: Rich Trott Reviewed-By: Michaƫl Zasso Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Mestery Reviewed-By: Michael Dawson Reviewed-By: Danielle Adams --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 74a31d75d60f02..27be0e2e947f4b 100644 --- a/README.md +++ b/README.md @@ -635,6 +635,8 @@ Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys): * **Beth Griggs** <bgriggs@redhat.com> `4ED778F539E3634C779C87C6D7062848A1AB005C` +* **Bryan English** <bryan@bryanenglish.com> +`141F07595B7B3FFE74309A937405533BE57C7D57` * **Colin Ihrig** <cjihrig@gmail.com> `94AE36675C464D64BAFA68DD7434390BDBE9B9C5` * **Danielle Adams** <adamzdanielle@gmail.com> @@ -661,6 +663,7 @@ to sign releases): ```bash gpg --keyserver pool.sks-keyservers.net --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C +gpg --keyserver pool.sks-keyservers.net --recv-keys 141F07595B7B3FFE74309A937405533BE57C7D57 gpg --keyserver pool.sks-keyservers.net --recv-keys 94AE36675C464D64BAFA68DD7434390BDBE9B9C5 gpg --keyserver pool.sks-keyservers.net --recv-keys 74F12602B6F1C4E913FAA37AD3A89613643B6201 gpg --keyserver pool.sks-keyservers.net --recv-keys 71DCFD284A79C3B38668286BC97EC7A07EDE3FC1 From 1382a39eb75e52e791d540a32460bd99a1ffdcd0 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Tue, 15 Mar 2022 15:53:48 -0400 Subject: [PATCH 2/2] build: pin Windows GitHub runner to windows-2019 Node.js 14 currently doesn't support building with Visual Studio 2022. For now, pin the Windows workflow to run on `windows-2019` instead of `windows-latest`. --- .github/workflows/build-windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index e30274c47ad033..961bc41e394631 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -17,7 +17,7 @@ env: jobs: build-windows: - runs-on: windows-latest + runs-on: windows-2019 steps: - uses: actions/checkout@v2 - name: Set up Python ${{ env.PYTHON_VERSION }}