Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertising package #2477

Closed
traverseda opened this issue Aug 28, 2019 · 2 comments
Closed

Advertising package #2477

traverseda opened this issue Aug 28, 2019 · 2 comments

Comments

@traverseda
Copy link

It looks like this project depends on https://github.com/feross/funding, a project intended to show advertising in a projects build log.

It's my understanding that right now there aren't any advertising messages actually showing, but if you're uncomfortable with the possibility of advertisements in build logs that's something you might want to look into.

@richardlau
Copy link
Member

This came in as part of the update for standard to 14 (#2451). See standard/standard#1381.

@Trott
Copy link
Member

Trott commented Aug 29, 2019

Note that this does not effect end users of the site. For that matter the package does nothing at this point and will do nothing in the future as the terminal-ad thing is basically abandoned.

The dependency seems likely to be removed in a subsequent version of standard.

I don't think there's much reason to leave this open. However, if someone wants to open a pull request to eliminate it, any conversation can continue in the pull request. (Or for that matter, it can continue here. Comments on closed issues are certainly permitted.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants