Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py clean should call cargo clean #13

Open
botev opened this issue Mar 4, 2017 · 1 comment
Open

setup.py clean should call cargo clean #13

botev opened this issue Mar 4, 2017 · 1 comment

Comments

@botev
Copy link

botev commented Mar 4, 2017

I think this makes sense. I'm not too sure if it is easy to do though as I'm not too familiar with python packaging.

Also on a side note, is there anyway to pass to setup.py the list of features we want to build and install with cargo?

@novocaine
Copy link
Owner

+1 for clean yes let's see what we can do. we just need a new cmd class overriding the existing clean cmd class, then users can mount that as clean or rust_clean if they don't like overriding the default

on CLI flags passed through - yes should be fine, we just need to come up with a convention for it and maybe you can file a separate issue with an example

see https://github.com/novocaine/rust-python-ext/blob/master/rust_ext/__init__.py#L22 for how --inplace is accepted (this is picked up the distutils superclass and set on self.inplace auto-magically)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants