Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation & Cloud formation scripts #1

Open
npiper opened this issue Mar 22, 2023 · 0 comments
Open

Update documentation & Cloud formation scripts #1

npiper opened this issue Mar 22, 2023 · 0 comments

Comments

@npiper
Copy link
Owner

npiper commented Mar 22, 2023

Add doco update that had to change the role to add another wildcard match for each new Repo using the AWS + Github OpenID Connect approach (Still easier than AWS Keys), possibly worth trialling with a user level wildcard on the subject;

https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services

npiper-githubactions-role:

           "Action": "sts:AssumeRoleWithWebIdentity",
            "Condition": {
                "StringLike": {
                    "token.actions.githubusercontent.com:sub": [
                        "repo:npiper/npiper-parent-org:*",
                        "repo:npiper/npiper-parent-pom:*"
                    ]
                }
            }

Also had to modify the bucket policy to make all public read only by default:

New writes on this method got created as non-public readable by default.

{
    "Version": "2008-10-17",
    "Id": "Policy1380877762691",
    "Statement": [
        {
            "Sid": "AllowPublicReadByDefault",
            "Effect": "Allow",
            "Principal": {
                "AWS": "*"
            },
            "Action": "s3:GetObject",
            "Resource": "arn:aws:s3:::solveapuzzle-repo/*"
        }
    ]
}
@npiper npiper changed the title Update documentation Update documentation & Cloud formation scripts Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant