Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npmInstallCommand is incorrect #53

Closed
isaacs opened this issue Nov 5, 2020 · 0 comments
Closed

[BUG] npmInstallCommand is incorrect #53

isaacs opened this issue Nov 5, 2020 · 0 comments

Comments

@isaacs
Copy link
Contributor

isaacs commented Nov 5, 2020

The default npmInstallCommand on https://github.com/npm/pacote/blob/latest/lib/fetcher.js#L98-L105 was copied from pacote 9, and may have made sense for npm v6. However, it's incorrect for npm v7 (and arguably was incorrect in npm v6 as well).

    this.npmInstallCmd = opts.npmInstallCmd || [
      'install',
      '--only=dev', // only install dev, not actually supported on v7, which is a bug
      '--prod', // only install prod, this overrides the --only=dev anyway, so no devs get installed!
      '--ignore-prepublish', // not a config we support in v7, but probably should? Also, maybe not a good idea here!
      '--no-progress',
      '--no-save',
      // should probably add --no-audit, why do the extra work?
    ]

Re: npm/cli#1865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant