Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception in Ideal_labeler when the given feature is not found #31

Open
yangarbiter opened this issue Dec 31, 2015 · 4 comments
Open
Labels

Comments

@yangarbiter
Copy link
Collaborator

https://github.com/ntucllab/libact/blob/interface-documentation/libact/labelers/ideal_labeler.py#L30

@lsc36
Copy link
Collaborator

lsc36 commented Dec 31, 2015

@lsc36
Copy link
Collaborator

lsc36 commented Dec 31, 2015

Current IdealLabeler seems to return a list of labels instead of the label. This should also be fixed.

self.y[np.where([...])[0]]

should be

self.y[np.where([...])[0]][0]

or

self.y[np.where([...])[0][0]]

then catch IndexError and reraise ValueError to indicate feature not found.

@lsc36
Copy link
Collaborator

lsc36 commented Dec 31, 2015

Opened issue #32. Please solve it first.

@lsc36
Copy link
Collaborator

lsc36 commented Dec 31, 2015

#32 closed. Let's move discussion under #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants