-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is data type "time" mapped to Float #177
Comments
To expand on this, what I've noticed is that, when the VSPK sends this back to VSD, the output ends up being 1.234E12 rather than the long version of the value, which VSD subsequently rejects. By replacing the definition of the object with one that uses Long instead of Float, the save works correctly. |
I looked at the specs files and it looks like any places that uses "time" might be ok to be replaced by "integer". There are a few attributes that express an average time (like average RTT) but those are set as "float" instead of "time". It looks like a safe change to make but we would need to fully test all of those fields to make those changes. We need to query all fields marked as "time" and make sure they return integers. Or ask the R&D team to investigate |
Should this be an integer or a long? Java Date represents its time in milliseconds as a long so should we be consistent with this? We only use one of the affected classes at the moment, but I have confirmed that switching the float to a long in that case works perfectly fine when retrieving and saving the objects. |
I mean "Integer" in the mathematical sense. But yes, a long to be more precise. |
Is there a reason why the data type "time" is mapped to
Float
(instead ofLong
)?monolithe/monolithe/generators/lang/java/converter.py
Line 40 in 6ca7664
This creates an issue when trying to set the
startDateTime
attribute from theScheduledTestSuite
object.http://nuagenetworks.github.io/vsd-api-documentation/v6/20.10.8/scheduledtestsuite.html#attr_startDateTime
The text was updated successfully, but these errors were encountered: