Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce build targets for nunit.engine.core assembly #1246

Closed
Tracked by #1258
CharliePoole opened this issue Oct 19, 2022 · 4 comments
Closed
Tracked by #1258

Reduce build targets for nunit.engine.core assembly #1246

CharliePoole opened this issue Oct 19, 2022 · 4 comments
Assignees
Milestone

Comments

@CharliePoole
Copy link
Collaborator

@rprouse @mikkelbu @jnm2 I'd particularly like your thoughts on this one including on the timing (i.e. 3.16 vs 4.0).

It seems as if the .Net 5.0 and 6.0 builds of nunit.engine.core are not needed. If we remove them, .Net Core 3.1 will be used and that seems sufficient. Eliminating those builds would simplify the project a bit.

I anticipated this idea when I created the .Net 7.0 agent - it doesn't have its own engine core build, but uses the 6.0 version.

I'd appreciate hearing about anything I'm missing in thinking about this! Do you think it's suitable for 3.16 or should it wait for 4.0, whenever that comes?

@jnm2
Copy link
Collaborator

jnm2 commented Oct 19, 2022

I agree. 3.16 sounds good.

@rprouse
Copy link
Member

rprouse commented Oct 20, 2022

I also agree that reducing the build targets makes sense and I don't see it as a breaking change so 3.16 is fine.

@CharliePoole
Copy link
Collaborator Author

Available from MyGet as version 3.16.0-dev00051

@CharliePoole CharliePoole added the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Oct 31, 2022
@CharliePoole CharliePoole removed the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Nov 5, 2022
@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.16.0

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants