From 76c7c6f9ea84a6d46c6b0eef0b1188c5d8b4c2e2 Mon Sep 17 00:00:00 2001
From: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
Date: Wed, 12 Jun 2024 02:06:45 -0700
Subject: [PATCH] build: Fix an incorrect make variable passed to goreleaser
 (#716)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**What problem does this PR solve?**:
The make variable reference was replaced recently in
https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/704/files#diff-fa98b7f1d4a049ad777fb9453f6657c512c8b715a9f8bc47dfd57f1143bbb930L14.

The new reference is to `GORELEASE_VERBOSE`, which is unset, and
goreleaser fails:

```shell
> make build-snapshot
▶ running go generate
make[1]: Entering directory '/home/dlipovetsky/nutanix/capi-runtime-extensions'
▶ configuring supported csi providers
make[1]: Leaving directory '/home/dlipovetsky/nutanix/capi-runtime-extensions'
▶ building snapshot
  ⨯ command failed                                   error=invalid argument "" for "--verbose" flag: strconv.ParseBool: parsing "": invalid syntax
```

Not sure how CI passed for #704, because this issue affects main.

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
---
 make/goreleaser.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/make/goreleaser.mk b/make/goreleaser.mk
index 7ce0cdffc..cd6993330 100644
--- a/make/goreleaser.mk
+++ b/make/goreleaser.mk
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 GORELEASER_PARALLELISM ?= $(shell nproc --ignore=1)
-GORELEASER_DEBUG ?= false
+GORELEASER_VERBOSE ?= false
 
 ifndef GORELEASER_CURRENT_TAG
 export GORELEASER_CURRENT_TAG=$(GIT_TAG)
@@ -21,7 +21,7 @@ build-snapshot: go-generate ; $(info $(M) building snapshot $*)
 .PHONY: release
 release: ## Builds a release with goreleaser
 release: go-generate ; $(info $(M) building release $*)
-	goreleaser --verbose=$(GORELEASER_DEBUG) \
+	goreleaser --verbose=$(GORELEASER_VERBOSE) \
 		release \
 		--clean \
 		--parallelism=$(GORELEASER_PARALLELISM) \
@@ -31,7 +31,7 @@ release: go-generate ; $(info $(M) building release $*)
 .PHONY: release-snapshot
 release-snapshot: ## Builds a snapshot release with goreleaser
 release-snapshot: go-generate ; $(info $(M) building snapshot release $*)
-	goreleaser --verbose=$(GORELEASER_DEBUG) \
+	goreleaser --verbose=$(GORELEASER_VERBOSE) \
 		release \
 		--snapshot \
 		--clean \