Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a #! prefix to nvm.sh #643

Closed
cig0 opened this issue Feb 2, 2015 · 4 comments
Closed

Add a #! prefix to nvm.sh #643

cig0 opened this issue Feb 2, 2015 · 4 comments

Comments

@cig0
Copy link

cig0 commented Feb 2, 2015

Hi,
Could you consider adding a shebang atop the file to ensure compatibility across shells?
Cheers,
-Martín
@cig0 cig0 changed the title Add #! prefix to nvm.sh Add a #! prefix to nvm.sh Feb 2, 2015
@ljharb
Copy link
Member

ljharb commented Feb 2, 2015

That would make the file executable - but nvm needs to be sourced.

Cross-shell compatibility is ensured by our tests running in multiple shells.

@ljharb
Copy link
Member

ljharb commented Feb 2, 2015

What would compatibility is it you think the shebang would ensure?

@cig0
Copy link
Author

cig0 commented Feb 2, 2015

Oops, this is why one need to have some sleep from time to time, please forgive me the noise... 🤦

Now regarding the sourcing error, I'm having trouble trying to source nvm with Fish 2.1.1 (on a Fedora 21 system); knowing that Fish isn't precisely POSIX compliant, is there a way to source nvm?

@ljharb
Copy link
Member

ljharb commented Feb 3, 2015

No, nvm doesn't currently support fish. Please see #303 for fish-related discussion.

@ljharb ljharb closed this as completed Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @cig0