Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider excluding UnnecessaryGetter in recommended-jenkinsfile #144

Closed
felipecrs opened this issue Dec 14, 2020 · 1 comment · Fixed by #140
Closed

Consider excluding UnnecessaryGetter in recommended-jenkinsfile #144

felipecrs opened this issue Dec 14, 2020 · 1 comment · Fixed by #140

Comments

@felipecrs
Copy link
Contributor

Since we don't create classes for declarative pipelines, this rule does not make sense. Often, all we have is a function defined globally:

boolean isTrue(boolean var) {
  return isTrue
}

pipeline {
  [...]
}

This rule would complain about the isTrue function name.

@felipecrs
Copy link
Contributor Author

I just created this issue so I can mention it in the PR.

@felipecrs felipecrs changed the title Consider excluding UnnecessaryGetter in recommended-jenkinsfile Exclude UnnecessaryGetter, FactoryMethodName, MethodReturnTypeRequired, and GStringExpressionWithinString in recommended-jenkinsfile Dec 14, 2020
@felipecrs felipecrs changed the title Exclude UnnecessaryGetter, FactoryMethodName, MethodReturnTypeRequired, and GStringExpressionWithinString in recommended-jenkinsfile Consider excluding UnnecessaryGetter in recommended-jenkinsfile Dec 14, 2020
@felipecrs felipecrs changed the title Consider excluding UnnecessaryGetter in recommended-jenkinsfile Exclude UnnecessaryGetter, FactoryMethodName, MethodReturnTypeRequired, and GStringExpressionWithinString in recommended-jenkinsfile Dec 14, 2020
@felipecrs felipecrs changed the title Exclude UnnecessaryGetter, FactoryMethodName, MethodReturnTypeRequired, and GStringExpressionWithinString in recommended-jenkinsfile Consider excluding UnnecessaryGetter in recommended-jenkinsfile Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant