Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpathconf: fix read_blacklist use of logging library #272

Open
aesteve-rh opened this issue Jun 29, 2022 · 1 comment
Open

mpathconf: fix read_blacklist use of logging library #272

aesteve-rh opened this issue Jun 29, 2022 · 1 comment
Labels
logs Enhancement or fixes to logs

Comments

@aesteve-rh
Copy link
Member

Currently, read_blacklist is using logging to log warnings to the console. But the function is called from the tool.config_lvm_filter module, so the logs will be hidden when using vdsm-tool.

We can fix it now and return some additional information that can be processed by the config_lvm_filter module and print the correct logs into sys.stdout.

Note that there is #258, which could allow passing the right logging context through a parameter as an alternate solution.

@aesteve-rh aesteve-rh added the logs Enhancement or fixes to logs label Jun 29, 2022
@nirs
Copy link
Member

nirs commented Jun 29, 2022

Passing a logger sounds like the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logs Enhancement or fixes to logs
Projects
None yet
Development

No branches or pull requests

2 participants