Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bluebird Dependency #701

Open
jwerre opened this issue Jul 14, 2021 · 3 comments
Open

Remove Bluebird Dependency #701

jwerre opened this issue Jul 14, 2021 · 3 comments

Comments

@jwerre
Copy link

jwerre commented Jul 14, 2021

We should be able to remove Bluebird as a dependency in favor of standard ES6 Promises.

@jwerre
Copy link
Author

jwerre commented Jul 16, 2021

It may be worth considering adding a feature where you could plug in your own Promise library (#621 (comment)). Since Bluebird has been such an integral part of this project many legacy applications may be depending on the extended Promise functionality that it offers. It would be much easier to plug in Bluebird in many cases that to rewrite all that code. Furthermore, if you're using a feature like Cancelations you might find yourself is a situation where upgrading is untenable. One module that did this well is Mongoosehere's what that looks like.

@duyleomessi
Copy link

Is this feature done?

@jwerre
Copy link
Author

jwerre commented Aug 6, 2021

Doesn't look like it:

var Promise = require('bluebird');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants