Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo semver-checks might exit 0 if it finds only publish = false crates in a workspace #424

Open
rcoh opened this issue Mar 30, 2023 · 1 comment
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@rcoh
Copy link

rcoh commented Mar 30, 2023

  1. Create a cargo workspace where all crates are set to publish = false
  2. cargo semver-checks check-release -v
    Without -v it seems to imply that all is well—it will silently skip all crates. Checking 0 crates is unlikely to be what the user expected, perhaps it should exist non-zero?
@obi1kenobi obi1kenobi transferred this issue from obi1kenobi/cargo-semver-checks-action Mar 30, 2023
@obi1kenobi obi1kenobi added A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Mar 30, 2023
@obi1kenobi
Copy link
Owner

I didn't add a test case specifically for workspaces full of publish = false crates, so I'm not going to close this right now, but #477 does add an explicit error if the selections contain no crates with library targets, so it's possible this case would be handled too.

@obi1kenobi obi1kenobi changed the title cargo semver-checks will exit 0 even if it skips all crates cargo semver-checks might exit 0 if it finds only publish = false crates in a workspace Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

2 participants