Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that WikipediaVersioned links resolve #1874

Closed
paolaroncaglia opened this issue May 27, 2021 · 5 comments
Closed

Check that WikipediaVersioned links resolve #1874

paolaroncaglia opened this issue May 27, 2021 · 5 comments
Assignees

Comments

@paolaroncaglia
Copy link
Contributor

Stemming from obophenotype/cell-ontology#1078
Note for self: double-check that WikipediaVersioned links resolve for the Uberon terms I created (e.g. 'left colic vein'). Check in OLS; Protege may be a different issue.

@paolaroncaglia
Copy link
Contributor Author

paolaroncaglia commented Oct 27, 2021

WikipediaVersioned links don't seem fully resolved yet to me, but perhaps they're fine as are?

OLS:
Screen Shot 2021-10-27 at 10 54 28

Protege:
Screen Shot 2021-10-27 at 10 55 21

@paolaroncaglia
Copy link
Contributor Author

@dosumis (and FYI anyone interested in SOP for adding Wikipedia dbxrefs)
Following up on this: WikipediaVersioned links now resolve in OLS (example in def here), but not yet in Protege. @dosumis wrote earlier that "I don't know how this is configured in Protege - may be hard wired" (here). In a separate thread here, David and Chris hint at the possibility of discussing Wikipedia vs WikipediaVersioned links further. @dosumis , please let CL and Uberon editors if we should be adding WikipediaVersioned links in a different way than what's current. Otherwise, this ticket can be closed. I'll remove my assignment and add to the tech board for now. Thanks!

@paolaroncaglia paolaroncaglia removed their assignment Feb 23, 2022
@shawntanzk
Copy link
Collaborator

Is this a protege problem then? should we write a ticket for Protege side to fix? If so does protege support the short links from the GO yaml?
I've added this to CL call.

@shawntanzk
Copy link
Collaborator

shawntanzk commented Mar 21, 2022

@hkir-dev
There should be a place in protege that has short name to link (eg Wikipedia to http://en.wikipedia.org/wiki/)
We should add the following:

WikipediaVersioned as: "https://en.wikipedia.org/w/index.php?title="
DOI as: "https://doi.org/"

@shawntanzk to think if there are any other expansions that should be inserted

@shawntanzk
Copy link
Collaborator

Fixed with protegeproject/protege#1049 - will be implemented in the next protege release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants