Text color of disabled menu item is incorrect

[paladin-t]

Version/Branch of Dear ImGui:

Version: 1.84.2
Branch: master

Back-end/Renderer/Compiler/OS

Back-ends: any
Compiler: any
Operating System: any

My Issue/Question:

bool ImGui::MenuItemEx(const char* label, const char* icon, const char* shortcut, bool selected, bool enabled)
{
	...
	if (!enabled)
		BeginDisabled(true);
	...
	RenderText(...);
	...
	if (!enabled)
		EndDisabled();
	...
}

void ImGui::RenderText(ImVec2 pos, const char* text, const char* text_end, bool hide_text_after_hash)
{
	...
	window->DrawList->AddText(g.Font, g.FontSize, pos, GetColorU32(ImGuiCol_Text), text, text_display_end);
	...
}

It always uses ImGuiCol_Text.

[ocornut]

As per #211 we introduced a general purpose "Disabled" mode and this introduced a little inconsistency.
MenuItem() are using ImGuiCol_Text + the Disabled modifier (style.DisabledAlpha).

This makes the existence of ImGuiCol_TextDisabled a little odd and maybe to be reworked/removed/redesigned.

I presume you are having an issue because your value for ImGuiCol_TextDisabled was e.g. using a different Hue than your value for ImGuiCol_Text ? How do things look in your style?

[paladin-t]

Thank you for your reply.

In this case, calling GetColorU32(ImGuiCol_Text) left the second parameter float alpha_mul omitted, which defaults to 1.0f. I don't think DisabledAlpha affects here.

ImU32 ImGui::GetColorU32(ImGuiCol idx, float alpha_mul/* = 1.0f*/)
{
    ImGuiStyle& style = GImGui->Style;
    ImVec4 c = style.Colors[idx];
    c.w *= style.Alpha * alpha_mul;
    return ColorConvertFloat4ToU32(c);
}

It looks like:

well it should be:

This issue remains despite how I adjust DisabledAlpha.

[ocornut]

I don't think DisabledAlpha affects here.

DisabledAlpha is baked into style.Alpha when going in Disabled mode.

Are you sure you are on 1.84.2 and not on 1.84 or 1.84.1 ?
There was a bug at some point which got fixed.

[paladin-t]

After debugging, it's a bug of my part, solved now. Thank you for your time.