Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL helpers.odin - Logging issue #4047

Open
RoboMage opened this issue Aug 10, 2024 · 0 comments
Open

OpenGL helpers.odin - Logging issue #4047

RoboMage opened this issue Aug 10, 2024 · 0 comments

Comments

@RoboMage
Copy link

Context

In the OpenGL vendor library in the helpers.odin in check_error on lines 70 and 78 there's two commented out procedure calls for the print statements. With these commented out the entire function doesn't seem to serve any purpose. Also the commented out procs are undefined - "fmt.printf_err". If you replace it with fmt.eprintf everything works fine.

I am also confused on why there are two near identical functions called check_error here. Only differences is one doesn't print anything. If I'm way off the mark here, please let know

  • Operating System & Odin Version:
    Odin: dev-2024-08-nightly:8359995
    OS: Windows 10 Professional (version: 22H2), build 19045.4651
    CPU: AMD Ryzen 9 5950X 16-Core Processor
    RAM: 32688 MiB
    Backend: LLVM 18.1.8

Expected Behavior

load_shaders_source from the OpenGL helpers library should be logging errors

Current Behavior

No errors are currently getting logged

Steps to Reproduce

  • import gl "vendor:OpenGL"
  • Create an OpenGL context + window.
  • Create shader files or strings with a syntax error in it
  • Call gl.load_shaders_source(vertex_source, fragment_source)
  • Be sad when no errors are logged to the console

Failure Logs

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant