Error on crates depending on binary crates

[flodiebold]

If I have a workspace with a binary crate and another crate declaring a dependency on that binary crate (notwithstanding whether that makes sense), cargo metadata outputs a depedency with name null. Since cargo-metadata expects dependencies to always have a name, it fails to deserialize that metadata.

Here's a minimal reproduction: https://github.com/flodiebold/cargo-metadata-bug

[oli-obk]

Huh. Isn't that rather a bug in cargo metadata? Shouldn't it be emitting the binary crate's name?

[flodiebold]

I'm not sure. I guess since you can't really use the binary crate from the code, it puts null there? I haven't investigated it further so far...

[ehuss]

I mentioned this here, and have a PR to change it on the Cargo side (rust-lang/cargo#6534). However, there is some minor disagreement on how it should be fixed.

[ehuss]

This is now fixed on the latest nightly (via rust-lang/cargo#6534), so I think this can be closed.