Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django messages in SocialAuthExceptionMiddleware even for anonymous users #210

Closed
GregoryAveryWeir opened this issue Mar 7, 2014 · 3 comments

Comments

@GregoryAveryWeir
Copy link

Django's messages framework works for authenticated or unauthenticated users, so I propose removing the check in SocialAuthExceptionMiddleware that only uses messages for authenticated users.

@omab
Copy link
Owner

omab commented Mar 15, 2014

Do you happen to know since when it works?

@GregoryAveryWeir
Copy link
Author

I have not tested it, but the 1.2 docs say that the messages framework is a new feature "for both anonymous and authenticated clients:" https://docs.djangoproject.com/en/1.2/ref/contrib/messages/

It definitely works in 1.6.

@omab omab closed this as completed in 435fec3 Mar 23, 2014
@omab
Copy link
Owner

omab commented Mar 23, 2014

I've updated the code to use messages app by default. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants