Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google OAuth2 Disconnect #41

Closed
jchristman opened this issue Sep 27, 2013 · 1 comment
Closed

Google OAuth2 Disconnect #41

jchristman opened this issue Sep 27, 2013 · 1 comment

Comments

@jchristman
Copy link

I'm building a django application where I want users to be able to log in with their google accounts, do stuff, and logout. I am not wanting to keep data or anything like that, so I overrode the default disconnect pipeline and just removed the 'social.pipeline.disconnect.allowed_to_disconnect' check so that they would be able to disconnect without having any other information in the db (like a password). I modified the example app you provide to test this functionality but ran into a snag. When I click disconnect, it does not actually disconnect the user and still says "You are logged in as [username]." Here is some data for you.

[27/Sep/2013 09:17:56] "GET /login/google-oauth2/ HTTP/1.1" 302 0
[27/Sep/2013 09:17:57] "GET /complete/google-oauth2/?state=2elSzt1mWspvP9MuUc6mFAuzSarns0j5&code=4/RvBkG11KwhtQr9X_qOGqeGW1iSOe.Qur7pBQX2wAWmmS0T3UFEsO6zJG_ggI HTTP/1.1" 302 0
[27/Sep/2013 09:17:57] "GET /done/ HTTP/1.1" 200 1208
[27/Sep/2013 09:18:06] "POST /disconnect/google-oauth2/1/ HTTP/1.1" 302 0
[27/Sep/2013 09:18:06] "GET /done/ HTTP/1.1" 200 1169

image

image

If you need any more info, or if I am just doing something wrong, please let me know! Thanks!

@omab
Copy link
Owner

omab commented Sep 27, 2013

@suntzuII, disconnect doesn't mean logout, it will just disconnect the social reference to the user account. If you need to also logout the user that's apt to your project requirements and depends on you. You can do it easily by logout out the user in a pipeline method in the disconnect pipeline.

@omab omab closed this as completed Sep 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants