Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an ability to deploy AMB with existing implementation contracts #433

Open
akolotov opened this issue Jun 12, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@akolotov
Copy link
Collaborator

It is obvious that for further AMB adoption it could be a situation when one chain concentrates several AMB contracts of the same nature. Even for now there are two bridges ETH-xDai and ETH-POA as so the Foreign chain for them is the Ethereum Mainnet.

It means that all these bridges could have unique addresses but will share the same implementation. Since the bridge uses the proxy contract template, in order to safe gas and storage, it makes sense to have one implementation contract for all the bridges.

Deployment script does not support such option yet, so consider to implement a new configuration parameters like *_BRIDGE_IMPLEMENTATION and *_VALIDATORS_IMPLEMENTATIONS where the corresponding deployed contracts could be specified. If one of the parameters is configured, the scripts will skip deployment of the contracts and will use existing one instead.

@akolotov akolotov added the enhancement New feature or request label Jun 12, 2020
@akolotov
Copy link
Collaborator Author

akolotov commented Jul 1, 2020

Initial implementation of suggested changes has been started in https://github.com/poanetwork/tokenbridge-contracts/tree/existing-implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant