[Observer] Ambiguous references

[UlyanaAndrukhiv]

Problem Definition

Observer node builder has ambiguous references bootstrapNodeAddresses and bootstrapNodePublicKeys.

First from ObserverServiceConfig

flow-go/cmd/observer/node_builder/observer_builder.go

Lines 138 to 140 in 31007f0

	type ObserverServiceConfig struct {
	bootstrapNodeAddresses []string
	bootstrapNodePublicKeys []string

and another from FlowNodeBuilder

flow-go/cmd/scaffold.go

Lines 141 to 142 in 31007f0

	bootstrapNodeAddresses []string
	bootstrapNodePublicKeys []string

Proposed Solution

Since ObserverServiceBuilder embeds FlowNodeBuilder, it will inherit the bootstrapNodeAddresses and bootstrapNodePublicKeys fields from FlowNodeBuilder. This means can directly access these fields via ObserverServiceBuilder, avoiding duplication.

[peterargue]

are those fields used anywhere besides observer_builder.go?

[UlyanaAndrukhiv]

Those fields used also in follower_builder.go

are those fields used anywhere besides observer_builder.go?