Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reproducability #874

Closed
loeken opened this issue Apr 7, 2023 · 2 comments
Closed

improve reproducability #874

loeken opened this issue Apr 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@loeken
Copy link
Contributor

loeken commented Apr 7, 2023

Description

in the requirements.txt not all dependencies have a fixed version. with those other projects changing/bugs introduced its a bit hit/miss to not get a broken version when installing. I suggest to also add specific versions to all ( including a hash for the transformers which is pulled from git ). this will ensure users have the same dependcies.

Additional Context

Dependency pinning is useful because it ensures that a software application will use the exact version of its dependencies that have been tested and confirmed to work with that application. Without pinning, the application may use newer versions of its dependencies that have introduced breaking changes or other incompatibilities that cause the application to fail.

Dependency pinning also helps to ensure that the application will continue to work as expected even as the dependencies are updated over time. If a new version of a dependency is released that introduces breaking changes or other incompatibilities, the application will not automatically start using that version and potentially break as a result.

Overall, dependency pinning helps to ensure the stability and reliability of software applications, particularly in complex systems with many interdependent components.

@loeken loeken added the enhancement New feature or request label Apr 7, 2023
@oobabooga
Copy link
Owner

There is a trade off. Pinning packages requires additional maintenance, so I have only pinned packages that are more likely to break things, and left stable packages like numpy and requests unpinned.

@loeken
Copy link
Contributor Author

loeken commented Apr 7, 2023

while testing the docker stuff i did notice that both:

git+https://github.com/huggingface/transformers
sentencepiece

made some builds fail

What is the additional maintenance work - keeping track of new versions and testing/updating when those are released?

@loeken loeken closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants